Changeset 437 for gp/zope/lastfm

Timestamp:

07/04/07 02:42:53 (17 months ago)

Author:

gawel

Message:

when lastfm is dead, my site too. ouch !
this is an occasion to test my tolerance decorator
seems works fine :)

Location:

gp/zope/lastfm

Files:

• browser.py (modified) (1 diff)
• template.pt (modified) (1 diff)

gp/zope/lastfm/browser.py

@@ -4 +4 @@
 from lxml import etree
 from zope.publisher.browser import BrowserView
+from gp.decorators import tolerance
+import logging
 
 PREFIX = '/tmp'
 
+@tolerance(etree.XMLSyntaxError, IOError,
+           default=None,
+           logger=logging.getLogger('gp.lastfm'))
 def getxml(filename):
+    """return a ElementTree parsed from the file
     """
-    return a ElementTree parsed from the file
-    """
-    fd = open(os.path.join(PREFIX,filename))
+    fd = open(os.path.join(PREFIX, filename))
     doc = etree.parse(fd)
     fd.close()
     return doc.getroot()
 
+
 class LastfmView(BrowserView):
-    """
-    a view to render the xml
+    """a view to render the xml
     """
 
-    views = ((u'Coup de coeur','recentlovedtracks.xml'),
-             (u'Ecouté récemment','recenttracks.xml'))
+    views = ((u'Coup de coeur', 'recentlovedtracks.xml'),
+             (u'Ecouté récemment', 'recenttracks.xml'))
 
     def __call__(self):
         self.title, filename = random.choice(self.views)
         self.xml = getxml(filename)
-        return super(LastfmView,self).__call__()
+        return super(LastfmView, self).__call__()
 

gp/zope/lastfm/template.pt

@@ -1 @@
-<dl class="lastfm" tal:define="root view/xml">
+<dl class="lastfm"
+    tal:define="root view/xml|nothing"
+    tal:condition="nocall:root">
   <dt class="title" tal:content="view/title" />
   <dd tal:repeat="track root">
       <a tal:attributes=" href track/find:url/text">
         <span tal:content="track/find:name/text" />
-        <span class="small" 
+        <span class="small"
               tal:content="track/find:artist/text" />
       </a>